Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated project settings, int -> NSInteger, fixed warnings and deprecations #119

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated project settings, int -> NSInteger, fixed warnings and deprecations #119

wants to merge 2 commits into from

Conversation

shazron
Copy link

@shazron shazron commented Sep 13, 2018 •
edited
Loading

  • Updated project settings to recommended in Xcode 9.4.1
  • int -> NSInteger, intValue -> integerValue
  • Added imageUTIs, imageExtensionsFromUTIs methods (needed when upgrading the deprecated method imageFileTypes. Replacement method imageTypes returns utis now)

@shazron
Updated project settings, int -> NSInteger, fixed warnings and deprec…
1a7fa8e 
…ations

int -> NSInteger, intValue -> integerValue
Added imageUTIs, imageExtensionsFromUTIs methods
MaddTheSane
MaddTheSane reviewed Sep 13, 2018
View reviewed changes
Frameworks/XADMaster.framework/Versions/A/Headers/XADArchive.h Outdated
@@ -33,7 +33,7 @@ extern NSString *XADFinderFlags;
NSMutableDictionary *namedict;

off_t extractsize,totalsize;
int extractingentry;
NSInteger extractingentry;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like you updated the XADMaster library itself. Editing headers of compiled libraries must be done with care.

Good news is that XADMaster (or a previous version of it) is open-source.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops yeah this was a general copy and replace mostly, I will revert changes from the Frameworks folder. I see several mirrors/forks of XADMaster, which one does Simple Comic derive the framework from? Any others that I should look at with this code review? Thanks!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like 2 files need to be reverted:

  1. Frameworks/XADMaster.framework/Versions/A/Headers/CSInputBuffer.h
  2. Frameworks/XADMaster.framework/Versions/A/Headers/XADArchive.h

I found this to be the official repo: https://github.com/MacPaw/XADMaster

@shazron
Copy link
Author

shazron commented Sep 17, 2018

Added commit to revert unwanted changes in Frameworks folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaddTheSane MaddTheSane MaddTheSane left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shazron @MaddTheSane