Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add managed identity support to app insights serilog sink #548

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

stijnmoreels
Copy link
Member

Adds managed identity support to the Serilog Application Insights sink that lets you provide a client ID together with the ingestion connection string towards Azure Application Insights.

Closes #541

@stijnmoreels stijnmoreels self-assigned this Oct 27, 2023
@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for arcus-observability canceled.

Name Link
🔨 Latest commit 35f91eb
🔍 Latest deploy log https://app.netlify.com/sites/arcus-observability/deploys/655c621f69d2b700081fd4aa

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f663587) 86.96% compared to head (35f91eb) 87.90%.
Report is 2 commits behind head on main.

Files Patch % Lines
...ts/Extensions/LoggerSinkConfigurationExtensions.cs 97.82% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
+ Coverage   86.96%   87.90%   +0.93%     
==========================================
  Files          70       69       -1     
  Lines        2593     2604      +11     
  Branches      151      149       -2     
==========================================
+ Hits         2255     2289      +34     
+ Misses        294      268      -26     
- Partials       44       47       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stijnmoreels
Copy link
Member Author

/azp run CI - Arcus.Observability

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure AD Authentication In the ApplicationInsights Sink
1 participant