-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flake8-logging
] Stabilize root-logger-call
(LOG015
)
#16654
Conversation
Summary -- Stabilizes LOG015. The tests and docs looked good. Test Plan -- 1 closed documentation issue from 4 days after the rule was added, but no other issues or PRs.
CodSpeed Performance ReportMerging #16654 will degrade performances by 10.81%Comparing Summary
Benchmarks breakdown
|
|
code | total | + violation | - violation | + fix | - fix |
---|---|---|---|---|---|
LOG015 | 287 | 287 | 0 | 0 | 0 |
RUF100 | 1 | 0 | 1 | 0 | 0 |
Linter (preview)
✅ ecosystem check detected no linter changes.
There's -1 RUF100 violation in the ecosystem results, which actually makes sense. I guess rotki was running on preview and needed the noqa, which caused RUF100 on stable. Now LOG015 is stable and the noqa is no longer unused. Everything else looks like a true positive to me. |
Summary
Stabilizes LOG015. The tests and docs looked good.
Test Plan
1 closed documentation issue from 4 days after the rule was added, but no other issues or PRs.