POLICY-166: Linking and Unlinking API improvements #3912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arpit-at
changed the title
nikhilbonte21
requested changes
Jan 2, 2025
intg/src/main/java/org/apache/atlas/model/instance/BusinessPolicyRequest.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
Outdated
Show resolved
Hide resolved
| import org.apache.commons.lang3.StringUtils; | ||
| import org.javatuples.Pair; |
There was a problem hiding this comment.
imports are not used, please remove
| Set<String> newCompliantPolicies = data.getComplaintPolicies(); | ||
|
|
||
| // Calculate effective compliant and non-compliant policies | ||
| Set<String> effectiveCompliant = calculateEffectivePolicies(existingCompliant, newCompliantRules, newCompliantPolicies); |
There was a problem hiding this comment.
instead of existingCompliant/newCompliantRules/newCompliantPolicies, can we rewrite as existingCompliantGuids/newCompliantRuleGuids/newCompliantGuids
Overall, suggesting mentioning that all these fields stores policy/Rule GUIDs
This also applies to the fields in the model class BusinessPolicyRequest.AssetData
There was a problem hiding this comment.
I have changed it, but not in AssetData, as it will require making the changes in all the integrations everywhere but I have added clarifying comments on top of each attribute, hope it works
nikhilbonte21
previously approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Type of change
Related issues
Checklists
Development
Security
Code review