Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MESH-299 | Audit Search Logs #3928

Merged
merged 9 commits into from
Jan 14, 2025
Merged

MESH-299 | Audit Search Logs #3928

merged 9 commits into from
Jan 14, 2025

Conversation

ankitpatnaik-atlan
Copy link
Collaborator

@ankitpatnaik-atlan ankitpatnaik-atlan commented Dec 30, 2024 •
edited
Loading

Change description

Enhanced audit logs to include changes in the attributes as per issue.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable
Screenshot 2025-01-13 at 5 31 07 PM Screenshot 2025-01-13 at 1 47 21 PM

@ankitpatnaik-atlan ankitpatnaik-atlan changed the title MESH-299: Audit Search Logs MESH-299 | Audit Search Logs Dec 30, 2024
PRATHAM2002-DS
PRATHAM2002-DS previously approved these changes Jan 2, 2025
View reviewed changes
@nikhilbonte21
Copy link

LGTM, merge after successful validation on staging branch

@PRATHAM2002-DS PRATHAM2002-DS merged commit f15fcb2 into master Jan 14, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krsoninikhil krsoninikhil krsoninikhil left review comments

@nikhilbonte21 nikhilbonte21 nikhilbonte21 approved these changes

@PRATHAM2002-DS PRATHAM2002-DS PRATHAM2002-DS left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ankitpatnaik-atlan @nikhilbonte21 @krsoninikhil @PRATHAM2002-DS