Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISC-458 | Autocomplete suggestion endpoint #3954

Merged
merged 5 commits into from
Jan 13, 2025
Merged

Conversation

utsav-ladia-atlan
Copy link
Collaborator

@utsav-ladia-atlan utsav-ladia-atlan commented Jan 8, 2025

Change description

Added the endpoint for search suggestion to handle the post request and get autocomplete suggestions.

Description here
Tested the /search/suggestions endpoint with post request and test query.
Received the expected matched result from the ES running locally through this endpoint.

Screenshot 2025-01-12 at 10 07 19 PM

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix [DISC-458]()

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@utsav-ladia-atlan utsav-ladia-atlan changed the title Added back the search suggestion endpoint DISC-458 | Added back the search suggestion endpoint Jan 12, 2025
@utsav-ladia-atlan utsav-ladia-atlan changed the title DISC-458 | Added back the search suggestion endpoint DISC-458 | Autocomplete suggestion endpoint Jan 12, 2025
@sumandas0 sumandas0 merged commit 6a08d8c into beta Jan 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants