Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DG-1988 Minor improvements on append/remove/replace for Tags #3957

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hr2904
Copy link
Collaborator

@hr2904 hr2904 commented Jan 9, 2025

Change description

Removing UpdateClassification array. AppendClassification (being renamed to addOrUpdate) will be responsible for add/update based on classification state in atlas. Incase classification doesnt exist , add flow will be used, otherwise any change or no change in config in a pre-existing classification will be treated for update flow.
For Remove Classification Flow, not going to throw any error, instead will be silently logging it in case the classification in the array doesnt exist with Atlas.

Type of change

  • New feature (adds functionality)

Related issues

Fix #1
Testcases
Thread

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

hr2904 added 2 commits January 8, 2025 21:57
…med to addOrUpdate) will be responsible for add/update based on classification state in atlas. Incase classification doesnt exist , add flow will be used, otherwise any change or no change in config in a pre-existing classification will be treated for update flow.

For Remove Classification Flow, not going to throw any error, instead will be silently logging it in case the classification in the array doesnt exist with Atlas.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants