Skip to content

Conversation

JakeLane
Copy link
Contributor

@JakeLane JakeLane commented Sep 11, 2025

Motivation

  • Excessive use of type suppressions reduces type safety.

  • Insufficient type coverage, especially in tests or areas lacking check-ts.

  • Inconsistent test checking, with check-ts not functioning reliably across all environments.

Changes

Moving to typescript project references, which is the modern way to handle monorepos. This should improve reliablity and give us a single command for building/checking ts (yarn build:ts).

Also adding a type coverage command and comment to gamify the improvement of types.

Checklist

  • Existing or new tests cover this change
  • There is a changeset for this change, or one is not required
  • Added documentation for any new features to the docs/ folder

Copy link

changeset-bot bot commented Sep 11, 2025

⚠️ No Changeset found

Latest commit: 80b653a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JakeLane JakeLane force-pushed the ts-project-refs-and-coverage branch 2 times, most recently from e0060a7 to deacd12 Compare September 11, 2025 06:54
@JakeLane JakeLane force-pushed the ts-project-refs-and-coverage branch 3 times, most recently from a4138f0 to 675b98a Compare September 12, 2025 01:36
Copy link
Contributor

github-actions bot commented Sep 12, 2025

📊 Type Coverage Report

Overall Coverage

Metric Value
Coverage Percentage NaN%
Correctly Typed 0
Total Expressions 0
Untyped Expressions 0
Status ✅ Success

Note: No baseline data available to compare with.


This report was generated by the Type Coverage GitHub Action

@JakeLane JakeLane force-pushed the ts-project-refs-and-coverage branch from 675b98a to f71ea26 Compare September 12, 2025 01:42
@JakeLane JakeLane force-pushed the ts-project-refs-and-coverage branch from f71ea26 to baf21ba Compare September 12, 2025 01:55
Copy link

🦀 Ferris' Rust Changeset Check

Ferris says: Hi! I noticed you changed some .rs files but you didn't bump the Rust package.

If you want your Rust changes published, you will need to bump the @atlaspack/rust package in your changeset.

@JakeLane JakeLane marked this pull request as ready for review September 12, 2025 06:38
@JakeLane JakeLane requested a review from a team as a code owner September 12, 2025 06:38
@marcins
Copy link
Contributor

marcins commented Sep 12, 2025

Neat! What's the workflow when you modify dependencies in a package? Do you re-run the scripts/update-ts-references.mjs script? I guess CI will error if you don't (or is it fast enough to do in pre-commit?)

@JakeLane
Copy link
Contributor Author

Neat! What's the workflow when you modify dependencies in a package? Do you re-run the scripts/update-ts-references.mjs script? I guess CI will error if you don't (or is it fast enough to do in pre-commit?)

Just running yarn build:ts should be enough. I chucked it straight in the build script because it's pretty fast

@JakeLane JakeLane force-pushed the ts-project-refs-and-coverage branch from 20ca6f1 to 5f6d0eb Compare September 15, 2025 04:30
@JakeLane JakeLane merged commit da73a0a into main Sep 16, 2025
35 of 38 checks passed
@JakeLane JakeLane deleted the ts-project-refs-and-coverage branch September 16, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants