-
Notifications
You must be signed in to change notification settings - Fork 5
In-source @parcel/source-map and the native code into Atlaspack #789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 17c0457 The changes in this PR will be included in the next version bump. This PR includes changesets to release 113 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🦀 Ferris' Rust Changeset CheckI can see you have now included |
@@ -73,6 +74,16 @@ impl From<ParcelSourceMap> for SourceMap { | |||
} | |||
} | |||
|
|||
impl From<ParcelSourceMapExt> for SourceMap { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is only needed by the CSS transformer, I should probably just move this conversion in there directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is currently a copy of https://github.com/parcel-bundler/source-map/blob/master/parcel_sourcemap_node/src/lib.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole folder is a copy of https://github.com/parcel-bundler/source-map/tree/master/parcel_sourcemap
Merging this into the existing atlaspack_sourcemap
would be a next step, as that crate is (mostly) a wrapper around this one.
packages/core/source-map/src/node.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The files in here are mostly copied from https://github.com/parcel-bundler/source-map/tree/master/src, with a conversion to TS and other minor changes to make things work with TS.
d7904d4
to
17c0457
Compare
Motivation
We want to interate / experiment with changes to source maps, and currently as an external library this is complicated. If we in-source the source map library we are free to make breaking changes that suit our use cases and Atlaspack more directly.
Changes
parcel_sourcemap
parcel_sourcemap
for the native CSS Transformer as it expects aparcel_sourcemap
as input@atlaspack/source-map
package that is what@parcel/source-map
wasChecklist
docs/
folder