fix(stats): Ignore leading environment variables when calculating stats #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinaryMuse
force-pushed
the
mkt/ignore-env-vars-in-stats
branch
from
43fe47b to
21bedb0
Compare
BinaryMuse
force-pushed
the
mkt/ignore-env-vars-in-stats
branch
from
21bedb0 to
9abab9a
Compare
BinaryMuse
changed the title
|
@ellie @BinaryMuse: you might want to add a few more tests to cover the syntax |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
atuin_history::stats::computeso that it makes a best attempt at ignoring leading environment variables when calculating the stats. This includes a new helper functionstrip_leading_env_varsthat has a few tests at the bottom of the file.Closes #2594
Checks