API support for fetching session token #802
Conversation
| @@ -29,7 +30,9 @@ public abstract class BaseCredentialsManager internal constructor( | |||
|
|
|||
| @Throws(CredentialsManagerException::class) | |||
| public abstract fun saveCredentials(credentials: Credentials) | |||
| public abstract fun saveSsoCredentials(ssoCredentials: SSOCredentials) | |||
There was a problem hiding this comment.
I'm not sure this method is needed. We're already providing a method for getting fresh SSOCredentials, which automaticaly saves the refresh token.
There was a problem hiding this comment.
The same functionality can also be achieved by simply retrieving the credentials, replacing the refresh token, and saving them back.
There was a problem hiding this comment.
In the case we have it for internal code reuse, then we should not have it be public.
There was a problem hiding this comment.
Added this method for the scenario where we get a new refresh token when calling the API directly from the AuthenticationAPI class. The user would have to call this to replace the existing one else the following getSsoCredentials call will fail.
| Mockito.`when`(storage.retrieveString("com.auth0.refresh_token")) | ||
| .thenReturn("refresh-token") | ||
| manager.saveSsoCredentials(ssoCredentials) | ||
| verify(storage).store("com.auth0.refresh_token", "refresh_token") |
There was a problem hiding this comment.
What is the difference between this test and the previous one?
There was a problem hiding this comment.
The previous one checks for scenario when the existing refresh_token is the same as the one received in the session token credentials and doesn't save it. This one checks for when we have separate refresh_token than the existing one and save it
There was a problem hiding this comment.
Yes, but they seem to be identical, line-by-line (except for the assert, of course).
There was a problem hiding this comment.
Agreed... everything is identical except the mocked value returned. which is what the test case is checking for . How the method will behave when the existing refresh_token is same and different from the new one
Changes
This PR adds support to fetch a session token, in exchange for a refresh token, to be used for SSO
Testing
This change adds unit test coverage
This change has been tested on the latest version of the platform/language or why not
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors