Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Move monitoring check from github action to code #3766

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

maru-ava
Copy link
Contributor

@maru-ava maru-ava commented Mar 5, 2025

Why this should be merged

This avoids requiring that downstream repos be able to produce a tmpnetctl binary.

How this works

  • Enables the e2e and upgrade suites to optionally run the monitoring check after network shutdown
  • Since the check runs in its own DeferCleanup, it's failure won't prevent tests or other cleanup from running

How this was tested

CI

Need to be documented in RELEASES.md?

N/A

@maru-ava maru-ava added the ci This focuses on changes to the CI process label Mar 5, 2025
@maru-ava maru-ava self-assigned this Mar 5, 2025
@maru-ava maru-ava force-pushed the ci-check-monitoring-from-code branch from fcb924c to 14a0e48 Compare March 8, 2025 13:28
@maru-ava maru-ava mentioned this pull request Mar 8, 2025
10 tasks
@maru-ava maru-ava force-pushed the ci-check-monitoring-from-code branch 2 times, most recently from d234056 to d42c38c Compare March 11, 2025 12:27
This avoids requiring that downstream repos be able to produce a
tmpnetctl binary.
@maru-ava maru-ava force-pushed the ci-check-monitoring-from-code branch from 3a2e53d to 7ecfe66 Compare March 13, 2025 00:57
@StephenButtolph StephenButtolph added this pull request to the merge queue Mar 13, 2025
Merged via the queue into master with commit 0bb475d Mar 13, 2025
23 checks passed
@StephenButtolph StephenButtolph deleted the ci-check-monitoring-from-code branch March 13, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This focuses on changes to the CI process
Projects
Status: Done ✅
Development

Successfully merging this pull request may close these issues.

3 participants