[tmpnet] Rename tmpnetctl main package from cmd to tmpnetctl #3787
+20
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maru-ava
added
testing
maru-ava
changed the title
maru-ava
commented
Mar 11, 2025
darioush
approved these changes
Mar 11, 2025
aaronbuchwald
approved these changes
Mar 11, 2025
StephenButtolph
approved these changes
Mar 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
This enables downstream repos to `go install` `tmptnetctl` rather than `cmd`.
maru-ava
force-pushed
the
tmpnet-rename-tmpnetctl-pkg
branch
from
6e41191 to
a42b2a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Previously the main package for tmpnetctl was named
cmd, which meant the binary resulting fromgo installwascmd. Renaming the package totmpnetctlis intended to allow downstream repos togo installtmptnetctfor use in CI.This is intended as a stopgap until tmpnetctl can be distributed with nix and avoid having to maintain a tmpnetctl script in downstream repos.
How this works
How this was tested
CI
Need to be documented in RELEASES.md?
N/A