Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace golang.org/x/exp with stdlib #1481

Closed
wants to merge 1 commit into from

Conversation

wangjingcun
Copy link

Why this should be merged

Since Go 1.21, the functions in x/exp used here can already be replaced by functions from the standard library

How this works

How this was tested

Need to be documented?

Need to update RELEASES.md?

@wangjingcun wangjingcun requested review from ceyonur, darioush and a team as code owners March 9, 2025 09:11
Signed-off-by: wangjingcun <wangjingcun@aliyun.com>
@qdm12
Copy link
Collaborator

qdm12 commented Mar 12, 2025

Thanks for the pull request! 🎖️
We currently have the code in subnet-evm based off geth v1.13.14 which contains these imports using the exp packages.
However, newer releases of geth contain the same changes as the proposed changes (only use non-exp imports) so these will be picked up automatically when we upgrade subnet-evm with the last geth release, and we want to keep differences with geth v1.13.14 to a minimum to have a smoother upgrade. I'll thus close this, but we appreciate the effort! 👍

@qdm12 qdm12 closed this Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants