Skip to content

Fix Invalid toJson parameter name #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2025
Merged

Fix Invalid toJson parameter name #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a79189e
fix invalid toJson parameter name
SentryMan Sep 1, 2025
00e5702
I think _ is more appropriate than $ here
rbygrave Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jsonb-generator/src/main/java/io/avaje/jsonb/generator/ClassReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ private void writeViewBuild(Append writer) {
@Override
public void writeToJson(Append writer) {
try {
final String varName = Util.initLower(shortName);
final String varName = "_" + Util.initLower(shortName);
writer.eol();
writer.append(" @Override").eol();
writer.append(" public void toJson(JsonWriter writer, %s %s) {", shortName, varName).eol();
Expand Down
28 changes: 28 additions & 0 deletions ...b-generator/src/test/java/io/avaje/jsonb/generator/models/valid/naming/PackageNaming.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
package io.avaje.jsonb.generator.models.valid.naming;

import io.avaje.jsonb.Json;

@Json
public class PackageNaming {
private final Package queryPackage;

public PackageNaming(Package queryPackage) {
this.queryPackage = queryPackage;
}

public Package getQueryPackage() {
return queryPackage;
}

public static class Package {
private final String ecosystem;

public Package(String ecosystem) {
this.ecosystem = ecosystem;
}

public String getEcosystem() {
return ecosystem;
}
}
}