feature: array adapter #3469

adrianthedev · 2024-11-28T21:17:49Z

Description

Fixes # (issue)

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
- array_resource docs.avohq.io#332
I have added tests that prove my fix is effective or that my feature works

codeclimate · 2024-11-28T21:18:15Z

Code Climate has analyzed commit 846e3dd and detected 0 issues on this pull request.

View more on Code Climate.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

rubocop

spec/dummy/app/avo/resources/movie.rb|115 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|120 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|125 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|130 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|135 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|140 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|145 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|150 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|155 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|160 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|165 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|170 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|175 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|180 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|185 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|190 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|195 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|200 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|205 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|210 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|215 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|220 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|225 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|230 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|235 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|240 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|245 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|250 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|255 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|260 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|265 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|270 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|275 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|280 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|285 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|290 col 35| [Corrected] Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
spec/dummy/app/avo/resources/movie.rb|291 col 8| [Corrected] Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array.

app/controllers/avo/array_controller.rb

spec/dummy/app/avo/resources/movie.rb

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

rubocop

spec/dummy/app/avo/resources/movie.rb|94 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|95 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|99 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|100 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|104 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|105 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|109 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|110 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|114 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|115 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|119 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|120 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|124 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|125 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|129 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|130 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|134 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|135 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|139 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|140 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|144 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|145 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|149 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|150 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|154 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|155 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|159 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|160 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|164 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|165 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|169 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|170 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|174 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|175 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|179 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|180 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|184 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|185 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|189 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|190 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|194 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|195 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|199 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|200 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|204 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|205 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|209 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|210 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|214 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|215 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|219 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|220 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|224 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|225 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|229 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|230 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|234 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|235 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|239 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|240 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|244 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|245 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|249 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|250 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|254 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|255 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|259 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|260 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|264 col 15| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/dummy/app/avo/resources/movie.rb|265 col 23| [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

spec/dummy/app/avo/resources/movie.rb

github-actions · 2024-12-28T02:05:21Z

This PR has been marked as stale because there was no activity for the past 15 days.

adrianthedev · 2025-01-08T15:13:40Z

Some exploration code:

Details

<div class="flex flex-col">
  <%
    fields = [:id, :name, :age]
    fields = {
      id: {
        type: :id,
        required: true
      },
      name: {},
      age: {
        type: :number,
      }
    }
    items = [
      {
        id: 123,
        name: "User",
        age: 14,
        email: "test@test.com",
      },
      {
        id: 124,
        name: "User 2",
        age: 15,
        email: "test2@test.com",
      },
      {
        id: 125,
        name: "User 3",
        age: 16,
        email: "test3@test.com",
        _options: {
          id_param: :id,
          show_path: "/users/123"
        }
      }
      # .name
      # [:name]
    ]

    options = {
      id_param: :id,
      path: "/users/123"
    }

    model_key = "users"
    cache_hash = [model_key, Digest::MD5.hexdigest(model_key)] # ai
    options = {}


    #Avo::Resources::Base.for_dumb(name: "Users", fields:, options:)
  %>

  <%#= render Avo::RecordTableComponent.new(name: "Users", items:, fields:, options:, data: {}) %>

  <%#= render Avo::RecordTableComponent.new(items:, fields:, options:, data: {}) %>
</div>

…ature/array-adapter

Paul-Bob · 2025-01-10T09:37:20Z

TODO:

Association array (field :movies, as: :array)
- Fetch values from:
  1. Block do ... end
  2. Model def movies
  3. Resource def records
Make it work with array of active records
- Enable the edit / delete links for it (not implementing for now)

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

rubocop

spec/dummy/app/avo/resources/event.rb|54 col 89| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
spec/dummy/app/avo/resources/event.rb|55 col 10| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
spec/dummy/app/avo/resources/event.rb|55 col 13| [Corrected] Layout/SpaceAfterColon: Space missing after colon.
spec/dummy/app/avo/resources/event.rb|55 col 90| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
spec/dummy/app/avo/resources/event.rb|56 col 10| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
spec/dummy/app/avo/resources/event.rb|56 col 13| [Corrected] Layout/SpaceAfterColon: Space missing after colon.
spec/dummy/app/avo/resources/event.rb|56 col 97| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
spec/dummy/app/avo/resources/event.rb|57 col 10| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
spec/dummy/app/avo/resources/event.rb|57 col 13| [Corrected] Layout/SpaceAfterColon: Space missing after colon.
spec/dummy/app/avo/resources/event.rb|57 col 84| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
spec/dummy/app/avo/resources/event.rb|58 col 10| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
spec/dummy/app/avo/resources/event.rb|58 col 13| [Corrected] Layout/SpaceAfterColon: Space missing after colon.
spec/dummy/app/avo/resources/event.rb|58 col 98| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
spec/dummy/app/avo/resources/event.rb|59 col 10| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
spec/dummy/app/avo/resources/event.rb|59 col 13| [Corrected] Layout/SpaceAfterColon: Space missing after colon.
spec/dummy/app/avo/resources/event.rb|59 col 93| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
spec/dummy/app/avo/resources/event.rb|60 col 10| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
spec/dummy/app/avo/resources/event.rb|60 col 13| [Corrected] Layout/SpaceAfterColon: Space missing after colon.
spec/dummy/app/avo/resources/event.rb|60 col 98| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
spec/dummy/app/avo/resources/event.rb|61 col 10| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
spec/dummy/app/avo/resources/event.rb|61 col 13| [Corrected] Layout/SpaceAfterColon: Space missing after colon.
spec/dummy/app/avo/resources/event.rb|61 col 96| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
spec/dummy/app/avo/resources/event.rb|62 col 10| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
spec/dummy/app/avo/resources/event.rb|62 col 13| [Corrected] Layout/SpaceAfterColon: Space missing after colon.
spec/dummy/app/avo/resources/event.rb|62 col 86| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
spec/dummy/app/avo/resources/event.rb|63 col 10| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
spec/dummy/app/avo/resources/event.rb|63 col 13| [Corrected] Layout/SpaceAfterColon: Space missing after colon.
spec/dummy/app/avo/resources/event.rb|63 col 95| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
spec/dummy/app/avo/resources/event.rb|64 col 10| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
spec/dummy/app/avo/resources/event.rb|64 col 13| [Corrected] Layout/SpaceAfterColon: Space missing after colon.
spec/dummy/app/avo/resources/event.rb|64 col 108| [Corrected] Layout/SpaceInsideHashLiteralBraces: Space inside } detected.

spec/dummy/app/avo/resources/attendee.rb

spec/dummy/app/avo/resources/event.rb

app/controllers/avo/associations_controller.rb

lib/avo/resources/array_resource.rb

spec/features/avo/array_resource_spec.rb

lib/avo/resources/array_resource.rb

adrianthedev

Awesome update. can't wait to have it up.
We had a refinement call and we decide to improve the API a bit.

Some explorations

# HasBaseField

      def initialize(id, **args, &block)
        super(id, **args, &block)
        @scope = args[:scope].present? ? args[:scope] : nil
        @attach_scope = args[:attach_scope].present? ? args[:attach_scope] : nil
        @display = args[:display].present? ? args[:display] : :show
        @searchable = args[:searchable] == true
        @hide_search_input = args[:hide_search_input] || false
        @description = args[:description]
        @use_resource = args[:use_resource] || nil

        # many frame base
        @discreet_pagination = args[:discreet_pagination] || false
        @link_to_child_resource = args[:link_to_child_resource]
        # Defaults to nil so that if not set falls back to `link_to_child_resource` defined in the resource

        has_many < has_base_field < base
        has_one < has_base_field < array_field < base # nu mai are sens
        has_many < has_base_field < array_field < base

        # aici ----
        array    < many_frame_base < frame_base_field < base
        has_one                    < frame_base_field < base
        has_many < many_frame_base < frame_base_field < base
        habtm    < many_frame_base < frame_base_field < base

        # nu se potri-  mutat in has_base
        @attach_fields = args[:attach_fields]

        # frame_base
        @reloadable = args[:reloadable].present? ? args[:reloadable] : false
        @linkable = args[:linkable].present? ? args[:linkable] : false
      end

app/components/avo/resource_component.rb

app/controllers/avo/associations_controller.rb

app/controllers/avo/base_application_controller.rb

app/controllers/avo/base_controller.rb

lib/avo/concerns/has_items.rb

adrianthedev · 2025-01-14T08:41:34Z

lib/avo/fields/has_many_field.rb

@@ -1,8 +1,11 @@
 module Avo
  module Fields
    class HasManyField < HasBaseField
+      attr_reader :array


Will we refactor it to ArrayField? I left our explorations in the review.

lib/avo/resources/resource_manager.rb

spec/dummy/app/models/course.rb

spec/system/avo/array_resource_spec.rb

app/controllers/avo/associations_controller.rb

feature: array adapter

eb9ad52

github-actions bot added the Feature label Nov 28, 2024

github-actions bot reviewed Nov 28, 2024

View reviewed changes

update ovei list

91d8b41

github-actions bot reviewed Dec 7, 2024

View reviewed changes

adrianthedev commented Dec 12, 2024

View reviewed changes

spec/dummy/app/avo/resources/movie.rb Outdated Show resolved Hide resolved

github-actions bot added the Stale label Dec 28, 2024

adrianthedev added Stale exempt and removed Stale labels Dec 29, 2024

adrianthedev assigned Paul-Bob Jan 8, 2025

Paul-Bob and others added 9 commits January 9, 2025 15:21

wip: hide unsupported actions, implement show view

5d2973a

some lint

e1ed8cd

revert indentation

e639cb8

Merge branch 'main' into feature/array-adapter

c789b97

lint

1fa0f72

Merge branch 'feature/array-adapter' of github.com:avo-hq/avo into fe…

b6868ae

…ature/array-adapter

lint

6355d8b

rm ActiveRecordResource for now

921330f

wip

3572078

Paul-Bob mentioned this pull request Jan 10, 2025

💡 allow embedding avo tables #2015

Open

rm ostruct requirement

30e4fb5

Paul-Bob and others added 3 commits January 10, 2025 13:06

make it work with array of active records

16dd5f9

Merge branch 'main' into feature/array-adapter

14cc44d

has_many field array option

dd1c32b

github-actions bot reviewed Jan 10, 2025

View reviewed changes

github-advanced-security bot found potential problems Jan 10, 2025

View reviewed changes

app/controllers/avo/associations_controller.rb Fixed Show fixed Hide fixed

github-actions bot reviewed Jan 13, 2025

View reviewed changes

lib/avo/resources/array_resource.rb Outdated Show resolved Hide resolved

Paul-Bob added 2 commits January 13, 2025 12:32

lint

24e266a

index tests

6fe69cb

github-actions bot reviewed Jan 13, 2025

View reviewed changes

spec/features/avo/array_resource_spec.rb Outdated Show resolved Hide resolved

spec/features/avo/array_resource_spec.rb Outdated Show resolved Hide resolved

Paul-Bob added 3 commits January 13, 2025 13:45

lint & flaky test

0a74f15

lint

21dbd3c

more tests

cee07ca

github-actions bot reviewed Jan 13, 2025

View reviewed changes

lib/avo/resources/array_resource.rb Outdated Show resolved Hide resolved

lib/avo/resources/array_resource.rb Outdated Show resolved Hide resolved

lib/avo/resources/array_resource.rb Show resolved Hide resolved

Paul-Bob added 11 commits January 13, 2025 15:20

lint

26a62de

wait_for_loaded on associations

2f5f5f3

rm copyable

ea17356

rm comments

4955d60

array resource check

61408b5

using_wait_time capybara

228579d

.

feda5d5

fix test

cd740df

.

50de07f

fix test

c42f23e

fix test

79058a8

Paul-Bob marked this pull request as ready for review January 13, 2025 17:36

Paul-Bob assigned adrianthedev Jan 13, 2025

adrianthedev commented Jan 14, 2025

View reviewed changes

Paul-Bob added 4 commits January 14, 2025 14:26

wip

163096b

wip

0972488

wip

af256db

wip

70743a6

github-advanced-security bot found potential problems Jan 15, 2025

View reviewed changes

app/controllers/avo/associations_controller.rb Dismissed Show dismissed Hide dismissed

Paul-Bob added 3 commits January 15, 2025 15:54

wip

da96679

fix test

c94d9fd

refactor wip

846e3dd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: array adapter #3469

feature: array adapter #3469

adrianthedev commented Nov 28, 2024 •

edited by Paul-Bob

Loading

codeclimate bot commented Nov 28, 2024 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot commented Dec 28, 2024

adrianthedev commented Jan 8, 2025

Paul-Bob commented Jan 10, 2025 •

edited

Loading

github-actions bot left a comment

adrianthedev left a comment

adrianthedev Jan 14, 2025

feature: array adapter #3469

Are you sure you want to change the base?

feature: array adapter #3469

Conversation

adrianthedev commented Nov 28, 2024 • edited by Paul-Bob Loading

Description

Checklist:

codeclimate bot commented Nov 28, 2024 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 28, 2024

adrianthedev commented Jan 8, 2025

Paul-Bob commented Jan 10, 2025 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

adrianthedev left a comment

Choose a reason for hiding this comment

adrianthedev Jan 14, 2025

Choose a reason for hiding this comment

adrianthedev commented Nov 28, 2024 •

edited by Paul-Bob

Loading

codeclimate bot commented Nov 28, 2024 •

edited

Loading

Paul-Bob commented Jan 10, 2025 •

edited

Loading