Lint botocore and s3transfer with --unsafe-fixes #9408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdaily
commented
Mar 28, 2025
kdaily
commented
Mar 28, 2025
kdaily
commented
Mar 28, 2025
kdaily
commented
Mar 28, 2025
kdaily
force-pushed
the
lint-unsafe-botocore-s3transfer
branch
from
d1bcc81 to
9d40c18
Compare
kdaily
commented
Mar 28, 2025
kdaily
commented
Mar 28, 2025
In `tests/functional/botocore/test_endpoint_rulesets.py`, the lines removed are used upstream to mark tests to be skipped. This is not required for AWS CLI v2 since AWS CRT is always installed as a dependency: https://github.com/boto/botocore/blob/a867a74b0d003c8cb8bfb4abc8f6e6d35bb792e4/tests/functional/test_endpoint_rulesets.py#L174-L189 In `tests/unit/botocore/test_credentials.py`, these lines are simply unused, and are not upstream either. Safe to remove.
aemous
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Ran
ruff check --fix --unsafe-fixes. Separated into three commits:UP030,UP031, andUP032).super()(fixesUP008)The miscellaneous fixes include (but not limited to):
The miscellaneous fixes were compared against botocore and unless otherwise noted they are already fixed in the same manner there.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.