Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use awscrt for cryptographic functionality in EC2 Instance Connect #9409

Merged
merged 9 commits into from
Apr 2, 2025

Conversation

kdaily
Copy link
Member

@kdaily kdaily commented Mar 28, 2025

Issue #, if available:

Description of changes:

This is a continuation of the work started in #9136.

This PR replaces cryptographic methods from the cryptography package with corresponding methods from the awscrt package for the AWS EC2 Instance Connect command:

  • aws ec2instanceconnect ssh

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

kdaily and others added 7 commits March 27, 2025 10:56

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This commit replaces the ED25519 methods to use the awscrt
implementation.

A notable difference is that we need to wrap the public and private key
inside a container ourselves (prefix on the public key, and wrap with
start/end blcok for the private key).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@kdaily kdaily force-pushed the crt-cryptography-ec2instanceconnect branch from 7460c9d to 56e4824 Compare March 29, 2025 00:36
@kdaily kdaily marked this pull request as ready for review March 31, 2025 17:33
@kdaily kdaily requested a review from ashovlin March 31, 2025 19:45
Copy link
Member

@ashovlin ashovlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested from my local Mac to an instance both with and without --private-key-file, both worked.

@kdaily kdaily merged commit 745d3ec into v2 Apr 2, 2025
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants