Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Aws credentials in cert manager package pod for e2e test #9455

Merged

Conversation

rajeshvenkata
Copy link
Member

Issue #, if available:
#9177

Description of changes:
In testing cert manger, we use access key and Id (see here) to test cert manager. ClusterIssuer does not have support for session token. One workaround is to use Ambient credentials approach where environment variables like AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY and AWS_SESSION_TOKEN are set in the cert manager pod.

In this PR, I am adding a test data (with AWS credentials - key, id, sessiontoken) for cert manager and use that to create cert manager pod and remove the current logic of using access key and id in the cluster issuer.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 21, 2025
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.54%. Comparing base (a87378e) to head (2141d0d).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9455      +/-   ##
==========================================
+ Coverage   69.47%   69.54%   +0.07%     
==========================================
  Files         672      672              
  Lines       49381    49432      +51     
==========================================
+ Hits        34307    34378      +71     
+ Misses      13288    13266      -22     
- Partials     1786     1788       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rajeshvenkata rajeshvenkata force-pushed the cert-manager-test-with-credentials branch from ecf4b34 to 5985f7d Compare March 21, 2025 07:58
@rajeshvenkata
Copy link
Member Author

/retest-required

1 similar comment
@rajeshvenkata
Copy link
Member Author

/retest-required

@rajeshvenkata rajeshvenkata force-pushed the cert-manager-test-with-credentials branch from 5985f7d to 2141d0d Compare April 7, 2025 21:20
@sp1999
Copy link
Member

sp1999 commented Apr 7, 2025

/lgtm

@sp1999
Copy link
Member

sp1999 commented Apr 7, 2025

/cherry-pick release-0.22

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.22 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999
Copy link
Member

sp1999 commented Apr 7, 2025

/cherry-pick release-0.21

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.21 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rajeshvenkata
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rajeshvenkata

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 315adc4 into aws:main Apr 7, 2025
9 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #9542

In response to this:

/cherry-pick release-0.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #9543

In response to this:

/cherry-pick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants