-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Aws credentials in cert manager package pod for e2e test #9455
Set Aws credentials in cert manager package pod for e2e test #9455
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9455 +/- ##
==========================================
+ Coverage 69.47% 69.54% +0.07%
==========================================
Files 672 672
Lines 49381 49432 +51
==========================================
+ Hits 34307 34378 +71
+ Misses 13288 13266 -22
- Partials 1786 1788 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ecf4b34
to
5985f7d
Compare
/retest-required |
1 similar comment
/retest-required |
5985f7d
to
2141d0d
Compare
/lgtm |
/cherry-pick release-0.22 |
@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.22 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-0.21 |
@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.21 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rajeshvenkata The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sp1999: new pull request created: #9542 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sp1999: new pull request created: #9543 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
#9177
Description of changes:
In testing cert manger, we use access key and Id (see here) to test cert manager. ClusterIssuer does not have support for session token. One workaround is to use Ambient credentials approach where environment variables like AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY and AWS_SESSION_TOKEN are set in the cert manager pod.
In this PR, I am adding a test data (with AWS credentials - key, id, sessiontoken) for cert manager and use that to create cert manager pod and remove the current logic of using access key and id in the cluster issuer.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.