Skip to content

Conversation

liumofei-amazon
Copy link
Contributor

Problem

Solution

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@liumofei-amazon liumofei-amazon requested a review from a team as a code owner August 22, 2025 22:48
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 51.77305% with 136 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.79%. Comparing base (df0f7d3) to head (2948fc2).

Files with missing lines Patch % Lines
...nguage-server/agenticChat/agenticChatController.ts 8.95% 61 Missing ⚠️
...-server/workspaceContext/workspaceFolderManager.ts 6.38% 44 Missing ⚠️
...-server/workspaceContext/workspaceContextServer.ts 0.00% 31 Missing ⚠️
Additional details and impacted files
@@                           Coverage Diff                           @@
##           feature/server-side-semantic-search    #2154      +/-   ##
=======================================================================
- Coverage                                59.84%   59.79%   -0.06%     
=======================================================================
  Files                                      254      255       +1     
  Lines                                    55904    56156     +252     
  Branches                                  3321     3331      +10     
=======================================================================
+ Hits                                     33456    33577     +121     
- Misses                                   22384    22515     +131     
  Partials                                    64       64              
Flag Coverage Δ
unittests 59.79% <51.77%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@liumofei-amazon liumofei-amazon force-pushed the workspaceContext_tool branch 3 times, most recently from 779934a to 10de36d Compare August 25, 2025 19:46
@liumofei-amazon liumofei-amazon force-pushed the workspaceContext_tool branch 3 times, most recently from ff060e9 to 48d7608 Compare August 25, 2025 21:11
@liumofei-amazon liumofei-amazon changed the base branch from main to feature/server-side-semantic-search August 26, 2025 21:45
@liumofei-amazon liumofei-amazon force-pushed the workspaceContext_tool branch 3 times, most recently from 33c28a7 to f524eb9 Compare September 2, 2025 20:19
@liumofei-amazon liumofei-amazon changed the base branch from feature/server-side-semantic-search to main September 2, 2025 20:31
@liumofei-amazon liumofei-amazon changed the base branch from main to feature/server-side-semantic-search September 2, 2025 21:27
LiGaCu
LiGaCu previously approved these changes Sep 3, 2025
@liumofei-amazon liumofei-amazon changed the base branch from feature/server-side-semantic-search to main September 3, 2025 23:21
@liumofei-amazon liumofei-amazon dismissed LiGaCu’s stale review September 3, 2025 23:21

The base branch was changed.

@liumofei-amazon liumofei-amazon changed the base branch from main to feature/server-side-semantic-search September 3, 2025 23:21
@@ -4671,8 +4735,8 @@ export class AgenticChatController implements ChatHandlers {
codeWhispererServiceToken
.listFeatureEvaluations({ userContext })
.then(result => {
const feature = result.featureEvaluations?.find(
feature => feature.feature === 'MaestroWorkspaceContext'
const feature = result.featureEvaluations?.find(feature =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need 'MaestroWorkspaceContext'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed for sending telemetry information for this ongoing MaestroWorkspaceContext. It's still ongoing experiment so we still need include it

@jguoamz jguoamz merged commit 0072cdf into aws:feature/server-side-semantic-search Sep 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants