Release spark 3.4 #128
Open
Release spark 3.4 #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxshe
reviewed
Oct 4, 2023
Pipfile.lock
Outdated
There was a problem hiding this comment.
Do we need to upload this file?
There was a problem hiding this comment.
I don't think so, let me try removing it from the commit.
There was a problem hiding this comment.
Removed in latest commit.
xiaoxshe
reviewed
Oct 4, 2023
| @@ -0,0 +1,17 @@ | |||
| [emr-apps] | |||
| name = EMR Application Repository | |||
| gpgkey = https://s3-REGION.amazonaws.com/repo.REGION.emr.amazonaws.com/apps-repository/emr-6.12.0/cfe221e4-88c4-464c-ad10-42f53049e5e7/repoPublicKey.txt | |||
There was a problem hiding this comment.
Just leave comment to remind, this has been checked against EMR release repo. EMR 6.12 supports spark 3.4
xiaoxshe
reviewed
Oct 4, 2023
| @@ -121,31 +121,9 @@ def sagemaker_session(boto_session, sagemaker_client) -> Session: | |||
|
|
|||
| @pytest.fixture(scope="session") | |||
| def is_feature_store_available(region) -> bool: | |||
| """Check if feature store is available in current region.""" | |||
| """Check if feature store is available in current region. Setting list empty since FS library not available for | |||
| spark releases later than 3.3. Otherwise it will fail tests during release.""" | |||
There was a problem hiding this comment.
worth to send offline message to feature store team on this to make sure they are aware of this.
There was a problem hiding this comment.
Yes, I got this confirmation from @can-sun and he requested me to disable test and installation of feature store library in the 3.4 release.
xiaoxshe
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Making changes for releasing spark 3.4
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.