fix: item attribute number limit issue

awslabs · Dec 15, 2023 · 788418b · 788418b
1 parent 4bb1f7b
commit 788418b
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/Sources/Clickstream/Dependency/Clickstream/Event/EventChecker.swift b/Sources/Clickstream/Dependency/Clickstream/Event/EventChecker.swift
@@ -166,6 +166,9 @@ class EventChecker {
     static func checkItem(currentNumber: Int, item: ClickstreamAttribute) ->
         (eventError: EventError, resultItem: ClickstreamAttribute)
     {
+        if itemKeySet.isEmpty {
+            initItemKeySet()
+        }
         var resultItem: ClickstreamAttribute = [:]
         if currentNumber >= Event.Limit.MAX_NUM_OF_ITEMS {
             let itemJsonString = (item as JsonObject).toJsonString()

diff --git a/Tests/ClickstreamTests/Clickstream/ClickstreamEventTest.swift b/Tests/ClickstreamTests/Clickstream/ClickstreamEventTest.swift
@@ -113,6 +113,22 @@ class ClickstreamEventTest: XCTestCase {
         XCTAssertEqual(0, clickstreamEvent.items.count)
     }
 
+    func testAddItemPrestAndCustomAttributeNotExceedTheLimit() {
+        var item: ClickstreamAttribute = [
+            ClickstreamAnalytics.Item.ITEM_ID: 123,
+            ClickstreamAnalytics.Item.ITEM_NAME: "testName1",
+            ClickstreamAnalytics.Item.ITEM_BRAND: "Google",
+            ClickstreamAnalytics.Item.CURRENCY: "CNY",
+            ClickstreamAnalytics.Item.LOCATION_ID: "1"
+        ]
+        for i in 0 ..< 10 {
+            item["custom_attr_\(i)"] = "value_\(i)"
+        }
+        clickstreamEvent.addItem(item)
+        XCTAssertTrue(clickstreamEvent.attribute(forKey: Event.ReservedAttribute.ERROR_CODE) == nil)
+        XCTAssertEqual(1, clickstreamEvent.items.count)
+    }
+
     func testAddItemErrorForExceedMaxLengthOfAttributeName() {
         let longAttributeKey = String(repeating: "a", count: 51)
         let item: ClickstreamAttribute = [