Merge pull request #22 from execjosh/bugfix/prevent-infinite-loop

fix(lint): Prevent infinite loop
babarot · Mar 10, 2020 · 59f1177 · 59f1177
2 parents e80f7d2 + 65464cd
commit 59f1177
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/lint/args.go b/lint/args.go
@@ -142,6 +142,9 @@ func handleYAML(path string) (files []File, err error) {
 		if err == io.EOF {
 			break
 		}
+		if err != nil {
+			return files, err
+		}
 		documents = append(documents, bytes.Trim(res, "\x00"))
 	}
 

diff --git a/lint/args_test.go b/lint/args_test.go
@@ -1,6 +1,7 @@
 package lint
 
 import (
+	"bufio"
 	"testing"
 )
 
@@ -112,3 +113,10 @@ func Test_filesFromArgs(t *testing.T) {
 		})
 	}
 }
+
+func Test_handleYAML_LineTooLong(t *testing.T) {
+	_, err := handleYAML("testdata/line-too-long.yaml")
+	if err != bufio.ErrTooLong {
+		t.Fatalf("want %q, got %q", bufio.ErrTooLong, err)
+	}
+}
diff --git a/lint/testdata/line-too-long.yaml b/lint/testdata/line-too-long.yaml