removed pin underscores in iomanagement.h #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bquan0
requested changes
Mar 9, 2025
bquan0
force-pushed
the
jack_koestering_combine_digital_analog
branch
from
9d97f07 to
2344c28
Compare
* Change IOManagement timer to TIM2 to not conflict with motor_control * Remove remnants of MC_ON being an output pin * Add testing code in main.cpp for IOManagement inputs
* Use new DAC library for analog outputs * Add output testing code in main.cpp
bquan0
force-pushed
the
jack_koestering_combine_digital_analog
branch
from
fb805bf to
6c4ac59
Compare
|
I will merge this in after some more testing with the Nucleo + PDC board. |
* add bit mask for forwardAndReverse CAN read msg * remove mc_on from CAN (it is now an input to PDC), use digital_data.mc_on instead * make state machine update at same rate as IO, not PID * set direction output based on forwardAndReverse (but only in IDLE state) * fix rpm calculation (it was too large by 1000x) after changing the interval from ms to µs broke it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed the underscore in pin definitions in iomanagement.h