Metal: MTLComputeCommandEncoder Dependency Structs #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaacMarovitz
force-pushed
the
structs
branch
from
a3dbcb5 to
06b52c2
Compare
Zorro666
requested changes
Jan 21, 2024
IsaacMarovitz
force-pushed
the
structs
branch
3 times, most recently
from
5c192da to
a26c2dd
Compare
IsaacMarovitz
force-pushed
the
structs
branch
2 times, most recently
from
56ed32f to
566ac2d
Compare
Zorro666
requested changes
Jan 23, 2024
There was a problem hiding this comment.
Thank you for the updates. It is looking very good.
There are a couple of minor things that would be good to change before the PR is merged.
Looking forward to seeing the replay work for compute (would need to be done in the WIP branch with replay support).
I will be continuing to upstream the Metal capture and replay work which will make things simpler for development in the future
AttributeFormat
SampleBufferAttachemnt Correction
Pipeline Descriptor Correction
IsaacMarovitz
force-pushed
the
structs
branch
from
566ac2d to
0a0c38b
Compare
Zorro666
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds serialisation code for all structs and enums that
MTLComputeCommandEncoderand its dependencies rely on.