Fix Mac compatibility for Vulkan 1.3.216+ #3258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to documentation https://vulkan.lunarg.com/doc/sdk/1.3.275.0/mac/getting_started.html since 1.3.216 VK_ERROR_INCOMPATIBLE_DRIVER should be provided to avoid VK_ERROR_INCOMPATIBLE_DRIVER error.
mirasrael
force-pushed
the
fix-macos-compatibilty
branch
from
d760b4f to
3ba1b30
Compare
Zorro666
reviewed
Feb 26, 2024
There was a problem hiding this comment.
I think this change is not wanted to upstream and best to keep local to your fork.
The rationale being:
- Mac is not officially supported or maintained by RenderDoc.
- There is more that needs to be done to get Vulkan to work on Mac with latest MoltenVk. This change is the first problem and some of the future problems are strictly speaking MoltenVk driver bugs that have to be worked around in RenderDoc.
- Personally I have had MoltenVk specific changes like this (and more) on my fork for a long time and the code has not conflicted and it has not been a trouble to keep the changes locally.
VK_KHR_portability_subsetis described asa provisional extension and must be used with caution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to documentation https://vulkan.lunarg.com/doc/sdk/1.3.275.0/mac/getting_started.html since 1.3.216 VK_ERROR_INCOMPATIBLE_DRIVER should be provided to avoid VK_ERROR_INCOMPATIBLE_DRIVER error.