Skip to content

Improve parsing of HTML tables containing whitespace #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve parsing of HTML tables containing whitespace #946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/trix/models/html_parser.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,10 @@ class Trix.HTMLParser extends Trix.BasicObject
@appendAttachmentWithAttributes(attributes, @getTextAttributes(element))
@processedElements.push(element)
when "tr"
unless element.parentNode.firstChild is element
unless element.parentNode.firstElementChild is element
@appendStringWithAttributes("\n")
when "td"
unless element.parentNode.firstChild is element
unless element.parentNode.firstElementChild is element
@appendStringWithAttributes(" | ")

# Document construction
Expand Down
2 changes: 1 addition & 1 deletion test/src/unit/html_parser_test.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ testGroup "Trix.HTMLParser", ->
assert.documentHTMLEqual Trix.HTMLParser.parse(html).getDocument(), expectedHTML

test "translates tables into plain text", ->
html = """<table><tr><td>a</td><td>b</td></tr><tr><td>1</td><td><p>2</p></td></tr><table>"""
html = """<table><tr>\r\n<td>a</td><td>b</td></tr><tr><td>1</td><td><p>2</p></td></tr><table>"""
expectedHTML = """<div><!--block-->a | b<br>1 | 2</div>"""
assert.documentHTMLEqual Trix.HTMLParser.parse(html).getDocument(), expectedHTML

Expand Down