Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExpressRoute Code #6

Merged
merged 35 commits into from
Oct 11, 2024
Merged

ExpressRoute Code #6

merged 35 commits into from
Oct 11, 2024

Conversation

AErmie
Copy link
Collaborator

@AErmie AErmie commented Sep 6, 2024

This Pull Request (PR) includes:

  • A separate module for:
    • Express Route Circuit
    • Express Route Circuit Peering
    • Express Route Connection

What's Been Tested:

  • Express Route circuit creation
  • Express Route circuit peering (AzurePrivatePeering specifically)
  • Express Route connection
    • Tested terraform plan, and executed terraform apply though apply failed (as expected) because the VPN Gateway is not deployed yet

image

image

Note

While performing terraform destroy to clean up the resources, the delete operation stepped on itself (ie. trying to delete the Circuit before/during the deletion of the Peering). This may be due to how each component is separated into its own module deployment.

@AErmie AErmie enabled auto-merge September 9, 2024 18:53
@AErmie AErmie requested review from wrnu and harsimranmaan September 9, 2024 18:53
@AErmie AErmie changed the title Initial Express Route Code ExpressRoute Code Sep 9, 2024
@AErmie AErmie merged commit 7cabbd4 into main Oct 11, 2024
2 checks passed
@AErmie AErmie deleted the express-route branch October 11, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants