Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: integrate Monad & Sonic #765

Merged
merged 8 commits into from
Feb 3, 2025
Merged

Conversation

TheDivic
Copy link
Collaborator

@TheDivic TheDivic commented Feb 3, 2025

📖 Context

Type of change

  • Non-breaking change (backwards compatible)

Why are we doing this?

  • Two new chain integrations (both broken unfortunately atm, until we get a response from the chain developers).
  • Code needed some refactoring to figure the bugs encountered during integration

What did we do?

  • Integrated (but disabled) Monad testnet, Sonic Mainnet & Sonic Blaze testnet
  • Some refactoring applied while debugging and working on these integrations, especially in the API layer.

How Has This Been Tested?

  • Monad works only for smart account creation, otherwise it will throw an error because the sender is not entrypoint, and we can't set the EP as sender or the RPC will throw sender not eoa. Waiting for fixes from the Monad team.
  • Sonic RPC still throw a gas error when calling eth_estimateGas. Waiting for fixes from the Sonic team.

Sonic is disabled for now because they have a RPC bug, but the integration is ready. As soon as they fix it we should just add the sonic chain IDs to supported networks
…bility problems

The very old version was throwing a warning about a package called 'punycode' being deprecated
Use npx depcheck & double check if it compiles
…s more readable

Use child loggers properly and measure execution
Remove dead code, reorganize code, improve logging
@TheDivic TheDivic requested a review from fichiokaku February 3, 2025 15:56
@TheDivic TheDivic self-assigned this Feb 3, 2025
@TheDivic TheDivic merged commit 7ebfebe into master Feb 3, 2025
5 checks passed
@TheDivic TheDivic deleted the integration/monad-sonic branch February 3, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant