Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import_task_before_choice event for singleton imports #5654

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix import_task_before_choice event for singleton imports #5654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8071d64
Improve import_task_before_choice event
marksdestiny Dec 6, 2024
5b9ecce
Merge branch 'master' into bugfix/events
marksdestiny Mar 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions beets/ui/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1117,6 +1117,22 @@ def choose_item(self, task):
"""
print_()
print_(displayable_path(task.item.path))

# Let plugins display info or prompt the user before we go through the
# process of selecting candidate.
results = plugins.send(
"import_task_before_choice", session=self, task=task
)
actions = [action for action in results if action]

if len(actions) == 1:
return actions[0]
elif len(actions) > 1:
raise plugins.PluginConflictError(
"Only one handler for `import_task_before_choice` may return "
"an action."
)

candidates, rec = task.candidates, task.rec

# Take immediate action if appropriate.
Expand Down