Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting to limit the bitrate. #50

Closed

Conversation

javierriveracastro
Copy link

First PR draft to solve issue #47.

It should be functional. I didn't use a slider but a hard number for both maximum frame rate and bit rate.

@bekriebel
Copy link
Owner

Thank you for submitting this!

I started taking a look at this today, but do have a couple of minor changes I wanted to put in. I also ran into an issue with the Testing Release of Foundry VTT v11 that I'm working to resolve. I'll work on those in tandem and should be able to include this in the next release.

@bekriebel bekriebel self-assigned this Apr 28, 2023
@bekriebel bekriebel added the enhancement New feature or request label Apr 28, 2023
@javierriveracastro
Copy link
Author

Thanks.

@javierriveracastro
Copy link
Author

This Pull Request doesn't work anymore with the last updates. I'm closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants