Skip to content

Add protobuf services for various entities #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ivucica
Copy link

@ivucica ivucica commented Apr 1, 2025

Add a new protobuf file proto/tibiawiki.proto implementing gRPC services for various entities.

  • Define the Book service with GetBook and ListBooks methods using google.api.http annotations.
  • Define the Building service with GetBuilding and ListBuildings methods using google.api.http annotations.
  • Define the Corpse service with GetCorpse and ListCorpses methods using google.api.http annotations.
  • Define the Creature service with GetCreature and ListCreatures methods using google.api.http annotations.
  • Define the Effect service with GetEffect and ListEffects methods using google.api.http annotations.
  • Define the HuntingPlace service with GetHuntingPlace and ListHuntingPlaces methods using google.api.http annotations.
  • Define the Item service with GetItem and ListItems methods using google.api.http annotations.
  • Define the Key service with GetKey and ListKeys methods using google.api.http annotations.
  • Define the Location service with GetLocation and ListLocations methods using google.api.http annotations.
  • Define the LootStatistic service with GetLootStatistic and ListLootStatistics methods using google.api.http annotations.
  • Define the Missile service with GetMissile and ListMissiles methods using google.api.http annotations.
  • Define the Mount service with GetMount and ListMounts methods using google.api.http annotations.
  • Define the NPC service with GetNPC and ListNPCs methods using google.api.http annotations.
  • Define the Object service with GetObject and ListObjects methods using google.api.http annotations.
  • Define the Outfit service with GetOutfit and ListOutfits methods using google.api.http annotations.
  • Define the Quest service with GetQuest and ListQuests methods using google.api.http annotations.
  • Define the Spell service with GetSpell and ListSpells methods using google.api.http annotations.
  • Define the Street service with GetStreet and ListStreets methods using google.api.http annotations.
  • Add docstrings to services and methods.

For more details, open the Copilot Workspace session.

ivucica added 2 commits April 1, 2025 04:10
Add a new protobuf file `proto/tibiawiki.proto` implementing gRPC services for various entities.

* Define the `Book` service with `GetBook` and `ListBooks` methods using google.api.http annotations.
* Define the `Building` service with `GetBuilding` and `ListBuildings` methods using google.api.http annotations.
* Define the `Corpse` service with `GetCorpse` and `ListCorpses` methods using google.api.http annotations.
* Define the `Creature` service with `GetCreature` and `ListCreatures` methods using google.api.http annotations.
* Define the `Effect` service with `GetEffect` and `ListEffects` methods using google.api.http annotations.
* Define the `HuntingPlace` service with `GetHuntingPlace` and `ListHuntingPlaces` methods using google.api.http annotations.
* Define the `Item` service with `GetItem` and `ListItems` methods using google.api.http annotations.
* Define the `Key` service with `GetKey` and `ListKeys` methods using google.api.http annotations.
* Define the `Location` service with `GetLocation` and `ListLocations` methods using google.api.http annotations.
* Define the `LootStatistic` service with `GetLootStatistic` and `ListLootStatistics` methods using google.api.http annotations.
* Define the `Missile` service with `GetMissile` and `ListMissiles` methods using google.api.http annotations.
* Define the `Mount` service with `GetMount` and `ListMounts` methods using google.api.http annotations.
* Define the `NPC` service with `GetNPC` and `ListNPCs` methods using google.api.http annotations.
* Define the `Object` service with `GetObject` and `ListObjects` methods using google.api.http annotations.
* Define the `Outfit` service with `GetOutfit` and `ListOutfits` methods using google.api.http annotations.
* Define the `Quest` service with `GetQuest` and `ListQuests` methods using google.api.http annotations.
* Define the `Spell` service with `GetSpell` and `ListSpells` methods using google.api.http annotations.
* Define the `Street` service with `GetStreet` and `ListStreets` methods using google.api.http annotations.
* Add docstrings to services and methods.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/benjaminkomen/TibiaWikiApi?shareId=XXXX-XXXX-XXXX-XXXX).
* **Book service**
  - Add docstrings for `GetBook` and `ListBooks` methods

* **Building service**
  - Add docstrings for `GetBuilding` and `ListBuildings` methods

* **Corpse service**
  - Add docstrings for `GetCorpse` and `ListCorpses` methods

* **Creature service**
  - Add docstrings for `GetCreature` and `ListCreatures` methods

* **Effect service**
  - Add docstrings for `GetEffect` and `ListEffects` methods

* ...etc
@ivucica
Copy link
Author

ivucica commented Apr 1, 2025

Note, this was experimental and not intended to end up as an actual visible PR. While it would be just cool to have a protobuf definition, I actually intend to drop this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant