Cleanup server code a bit #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjojo
reviewed
Jan 15, 2024
cmd/stayrtr/stayrtr.go
Outdated
| @@ -53,10 +53,15 @@ var ( | |||
|
|
|||
| ExportPath = flag.String("export.path", "/rpki.json", "Export path") | |||
|
|
|||
| RTRVersion = flag.Int("protocol", 2, "RTR protocol version. Version 2 is draft-ietf-sidrops-8210bis-10") | |||
| RTRVersion = flag.Int("rtr.protocol", 2, "RTR protocol version. Version 2 is draft-ietf-sidrops-8210bis-10") | |||
There was a problem hiding this comment.
I'd be a little cautious of changing this, as if people were using that flag, they will find that stayrtr will no longer start post upgrade
There was a problem hiding this comment.
I think there is some benefit in doing this but I can split out this part of the change into an extra PR.
Right now the stayrtr arguments are a hodgepodge.
|
But that has to be counterbalanced against basically breaking everybody's
upgrades and forcing people to change their config
…On Tue, Jan 16, 2024, 10:13 Claudio Jeker ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In cmd/stayrtr/stayrtr.go
<#111 (comment)>:
> @@ -53,10 +53,15 @@ var (
ExportPath = flag.String("export.path", "/rpki.json", "Export path")
- RTRVersion = flag.Int("protocol", 2, "RTR protocol version. Version 2 is draft-ietf-sidrops-8210bis-10")
+ RTRVersion = flag.Int("rtr.protocol", 2, "RTR protocol version. Version 2 is draft-ietf-sidrops-8210bis-10")
I think there is some benefit in doing this but I can split out this part
of the change into an extra PR.
Right now the stayrtr arguments are a hodgepodge.
—
Reply to this email directly, view it on GitHub
<#111 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALPK4WB47DALFMVGDWU3H3YOZHEDAVCNFSM6AAAAABB3KSYEGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMRSHE3TSMBTGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This is something that can be clearly communicated in the release notes. In the mean time I reverted that bit we can cycle back to that later. |
|
@cjeker can you rebase? |
|
done |
…ogether. Also support the "enforce rtr version" flag (the code for that is already there).
|
once more, I also moved the EnableNODELAY flag to where it belongs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some random cleanup while beating my head against the draft-ietf-sidrops-8210bis wall