Skip to content

Change cursor style on crosshair while selecting #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 15, 2016

Conversation

sadovnychyi
Copy link
Contributor

sample
#12

Ready to discuss ideas about improvements.
We, probably, should trigger style change on _middleMouseDown event as well? Ideas?

It's a bit annoying that you have to move a cursor a bit after a key down to apply new style. Any ideas how to fix this?

@kolomiichenko
Copy link

👍

@bigfive
Copy link
Owner

bigfive commented Jan 15, 2016

Nice

@sadovnychyi
Copy link
Contributor Author

It's a bit late.. Should I fix conflicts?

@sadovnychyi
Copy link
Contributor Author

Fixed

@bigfive
Copy link
Owner

bigfive commented Jan 15, 2016

You're a star. Thanks

bigfive added a commit that referenced this pull request Jan 15, 2016
Change cursor style on crosshair while selecting
@bigfive bigfive merged commit 792feaa into bigfive:master Jan 15, 2016
@sadovnychyi sadovnychyi deleted the patch-1 branch January 15, 2016 03:13
@bigfive
Copy link
Owner

bigfive commented Jan 15, 2016

Merged prematurely I'm afraid, had to revert. It looks like you removed middle mouse functionality

@sadovnychyi sadovnychyi restored the patch-1 branch January 15, 2016 03:16
@sadovnychyi
Copy link
Contributor Author

Is it related to this lines? I've removed them because this method is not used anywhere. Am I wrong?

_keyDown = (e) ->
  e[inputCfg.selectKey]

@bigfive
Copy link
Owner

bigfive commented Jan 15, 2016

Reopened here #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants