-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Docs - add sections and search filtering for community extensions #3260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs - add sections and search filtering for community extensions #3260
Conversation
I think this is an awesome addition. I think best practices would be to include a
|
For the main site search input the label text is hidden. <label for="extension-filter" hidden>Search Extensions:</label> |
Yeah, that sounds reasonable. I do know that labels are recommended by ARIA APG even if they are hidden. Typically a placeholder should not serve as a label and the contents of a placeholder are more for providing an example of what to fill in, but 🤷♂️ Also thanks for reminding me about the parent context: if the site search uses a |
That's a very cool enhancement! |
6a5249d
to
c1746b2
Compare
c1746b2
to
4a131c2
Compare
Updated ARIA based upon: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Roles/search_role |
Note: |
Thank you! |
Description
Try to make the community extensions docs table more approachable.
Current sections added: Data API, Integrations and Legacy.
Idea for additional section: We could put the
Alpine
andmorphdom
morphing extensions in a Morph section, but as there's just the two of them, I was on the fence about this, especially considering that currently the sections are at the end of the table.WARNING - this doesn't include PR #3259 and will need updating due to the change from markdown to html an table.Converted to a draft PR until that's been resolved.Implementation details
Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded