Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding lido.TokenRebased event table #658

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

ppclunghe
Copy link
Contributor

What?

Add, please, lido.TokenRebased event to data schema

How?

I used abi-parser to build the table definitions

Copy link
Collaborator

@kome12 kome12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments to fix the checks!

}
],
"table_description": "",
"table_name": "<TABLE_PREFIX>_event_TokenRebased"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the name of the table_name to be Lido_event_TokenRebased?

@ppclunghe
Copy link
Contributor Author

Thanks @kome12
fixed but tests still don't pass

@kome12
Copy link
Collaborator

kome12 commented Jan 24, 2024

Thanks @kome12 fixed but tests still don't pass

That test is fine to ignore for now. There seems to be some issue with the underlying package.

@kome12 kome12 merged commit 80ca7c8 into blockchain-etl:master Jan 24, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants