-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added arbitrum uniswap v3 factory and pools events, removed arbitrum uniswap factory nft events #688
Conversation
add arbitrum uniswap v3 positions nft events
add arbitrum uniswap v3 positions nft events (blockchain-etl#686)
add arbitrum uniswap v3 factory and pools events, remove factory nft events
What does "_open" suffix in the dataset name mean? Would it make sense to have "arbitrum_uniswap_v3" dataset instead of having separate "arbitrum_uniswap_v3_nft_positions" and "arbitrum_uniswap_v3_open"? |
I deleted arbitrum_uniswap_v3_nft_positions as it is not needed. |
Feature/arbitrum uniswap v3 events
Hi medvedev1088, I fixed this dataset name as we discussed. will be glad for your review. |
hi @medvedev1088 , i expected this commit to creating a dataset on big query with arbitrum date coming from log events of the contract I put in the JSON files. in practice, the same contract address also exists in Ethereum main net and the data I see in the tables is the Ethereum main net events, how and where do I specify the network to work with? Is it some definition on the JSON files or in the airflow project? I see some of the datasets work with layer 2 networks? can you please refer me to an article or guidance on that? |
What?
added arbitrum uniswap v3 factory and pools events, removed arbitrum uniswap factory nft events
How?
ie: I used abi-parser or cli tools to build the table definitions