Add per-IP rate limiters #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh no, i wonder if this was me. or partly from me. found my app crashed this morning with logs due to a bad event being served by the jetstream server: edit: moved the rest with more context to #24 since this was off-topic for rate-limiting. sorry for the comment spam! |
uniphil
added a commit
to uniphil/jetstream
that referenced
this pull request
Nov 18, 2024
The existing code doesn't `defer c.con.Close()` and exits early if reading encounters any error -- so `.Close()` is never called on the connection. This change stores any read and closing errors, `Join`ing them on return, ensuring that `.Close()` is always called. I'm not 100% sure but I hope this will help prevent the half-closed client connections referenced from bluesky-social#21 There is probably a more idiomatic way to do this (i am a go noob) but if i understand `errors.Join` and the current code, I think this should keep pretty close to the current intended behavior for any caller.
uniphil
added a commit
to uniphil/jetstream
that referenced
this pull request
Nov 18, 2024
The existing code doesn't `defer c.con.Close()` and exits early if reading encounters any error -- so `.Close()` is never called on the connection. This change stores any read and closing errors, `Join`ing them on return, ensuring that `.Close()` is always called. I'm not 100% sure but I hope this will help prevent the half-closed client connections referenced from bluesky-social#21 There is probably a more idiomatic way to do this (i am a go noob) but if i understand `errors.Join` and the current code, I think this should keep pretty close to the current intended behavior for any caller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing some weird behavior where some consumers will reconnect very aggressively like multiple times a second and trigger huge playbacks but half close the connection and open a new one. This sucks and I'll start with a basic IP-wide rate limiter but may move to rejecting connections if I see too many for one IP at some point.