✨ Export accounts from workspace to csv and add items from drag-n-drop csv #184
Conversation
components/workspace/hooks.tsx
Outdated
| repo.email || 'Unknown', | ||
| `${repo.ip || 'Unknown'}`, | ||
| `${profile?.displayName || 'Unknown'}`, | ||
| repo.labels?.map(({ val }) => val).join(', ') || 'None', |
There was a problem hiding this comment.
I almost wonder if an empty value could be more useful than a default value here. I suppose it depends how the CSV will be used.
There was a problem hiding this comment.
yeah I think our current use case is for mod folks to get these exports and review manually in which case, I feel like the explicit default values are more helpful.
components/workspace/hooks.tsx
Outdated
| repo.labels?.map(({ val }) => val).join(', ') || 'None', | ||
| buildBlueSkyAppUrl({ did: repo.did }), | ||
| ] | ||
| return line.join(',') |
There was a problem hiding this comment.
Values containing commas or newlines will end up breaking the CSV format. If we add some escaping we should be able to address it, though:
const escapeCSVValue = (value: string) => {
if (value.contains(',') || value.contains('"') || value.contains('\r') || value.contains('\n')) {
return `"${value.replaceAll('"', '""')}"`
}
return value
}
// ...
return line.map(escapeCSVValue).join(',')There was a problem hiding this comment.
yh except for labels/tags list, we don't have anything that contain those characters though but will add to make it more future proof.
foysalit
changed the title
| <WorkspaceItemCreator | ||
| onFileUploadClick={() => { | ||
| dropzoneRef.current?.open() | ||
| }} | ||
| /> |
There was a problem hiding this comment.
This uses two different patterns:
- Data binding through props
- Data binding through (some sort) of context
Sadly I don't see an easy way to do "clean" this. If you do, I'd change this, otherwise let's leave it.
lib/csv.ts
Outdated
| export function createCSV({ | ||
| headers, | ||
| lines, | ||
| filename, | ||
| lineDelimiter = '\n', | ||
| }: { | ||
| lines: string[] | ||
| headers: string[] | ||
| filename?: string | ||
| lineDelimiter?: string | ||
| }) { | ||
| return { | ||
| filename: (filename || Date.now().toString()) + '.csv', | ||
| headerRow: headers.join(',') + lineDelimiter, // make your own csv head | ||
| body: lines.join(lineDelimiter), | ||
| } | ||
| } |
There was a problem hiding this comment.
The return value does not match the returned type. Is there a particular reason for that ?
The data structure to represent the CSV here is a mix between encoded data (a multi line string of comma separated values, with the firt line being a header) and "parsed" data (internal data structure), Looks like we could benefit from defining and using a type interface (or even a class ?) for internal representation of CSVs:
type CsvContent = {
headers: string[]
rows: [][]
lineDelimiter: "," | ":" | "\t"
}There was a problem hiding this comment.
The return value does not match the returned type
not sure if I follow? the return type is expected to be CsvContent which i left implicit I guess. agreed we can tidy this up a bit more to make a more strict definition but for now the use-case is super low-stake so wanted to keep this flexible/open.
arcalinea
temporarily deployed
to
account-export - ozone-staging PR #184
Render
Destroyed
|
Jammed in one more feature here to allow profile bio/record content search in workspace filter panel. |
For record keeping, sharing data for further research and fill legal requests exporting data of a group of users is often done manually by mods. This is aimed to make that process much easier.
Also, allow drag-n-dropping a csv file and filling in workspace items from the csv content.