Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add theme switcher and dark mode to all places #23

Merged
merged 5 commits into from
Feb 9, 2024
Merged

Conversation

foysalit
Copy link
Contributor

@foysalit foysalit commented Feb 5, 2024

Screen.Recording.2024-02-05.at.17.09.56.mov

@foysalit foysalit requested review from devinivy and bnewbold February 5, 2024 16:31
@bnewbold
Copy link
Collaborator

bnewbold commented Feb 5, 2024

I can imagine we might move the toggle button somewhere smaller / less-obvious in the future, but seems fine for now.

Some build errors; i'd like to take a quick pass in preview build when those are fixed.

Copy link
Collaborator

@devinivy devinivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so nice!

@foysalit
Copy link
Contributor Author

foysalit commented Feb 5, 2024

@bnewbold yeah I stacked the PRs so the advanced filters on needs a version bump on atproto. once Devin releases the new version, I'll take care of that and have the preview branch ready for you!

@foysalit
Copy link
Contributor Author

foysalit commented Feb 6, 2024

@bnewbold synced up all 3 PRs, got the build errors fixed. you should be able to test everything now.

@foysalit foysalit changed the base branch from advanced-event-filters to main February 9, 2024 20:22
@foysalit foysalit merged commit 65cd2ba into main Feb 9, 2024
3 checks passed
@matthieusieben matthieusieben deleted the dark-mode branch November 15, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants