Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Optionally ack all subjects of an account when acknowledgi… #254

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

foysalit
Copy link
Contributor

@foysalit foysalit commented Dec 3, 2024

Depends on bluesky-social/atproto#3171

Screen.Recording.2024-12-03.at.23.21.26.mov

subjectStatus={modEvent.repo.moderation.subjectStatus}
/>
{subjectStatus && (
<ReviewStateIcon size="sm" subjectStatus={subjectStatus} />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugfix unrelated to the PR

@@ -1,12 +1,13 @@
import { SectionHeader } from '../../components/SectionHeader'
import { RepositoriesTable } from '@/repositories/RepositoriesTable'
import { useSearchParams } from 'next/navigation'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file are unrelated to the PR but I was working around this area so added these on.

  1. show loading state on repo list table
  2. use repo moderation states to show subject overview and subject status icon just like we do in the queue page instead of having it show just the handle in the first column and subject status in the last column.
  3. add quick action panel in repositories page so that mods can directly action accounts from the page without having to go to profile screen first.
  4. improve moderation status loading performance by bulk fetching using getRepos instead of calling getRepo on every did.

Copy link
Contributor

@matthieusieben matthieusieben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice !

@arcalinea arcalinea temporarily deployed to ack-all-with-ack-event - ozone-staging PR #254 December 5, 2024 12:11 — with Render Destroyed
@foysalit foysalit merged commit 7aab439 into main Dec 5, 2024
3 checks passed
@SteveTownsend
Copy link

very cool, @nafo-moderation.bsky.social will get a lot of use out of this since we aggressively label accounts, and now can auto-ack the child reports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants