Feature/update kotlin version and migrate to gradle kotlin dsl #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o remove deprecation warnings.
bmaslakov
requested changes
May 14, 2023
Comment on lines
-37
to
+38
| for (j in -15 until -1) { | ||
| assertEquals(sqrt(i.toDouble()), sqrt(i.toDouble()), j.toDouble()) | ||
| for (j in 2 until 16) { |
There was a problem hiding this comment.
This looks like a functional change, the test intended to validate negative numbers
|
Mind also updating README.md to reference the actual version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've updated gradle to version 7.6.1 and kotlin to the most recent version 1.8.20. This required some small changes as some functions from kotlin-stdlib were renamed.
I also introduced the kotlin-tests libraries which provide an abstraction over junit. With this change I also replaced junit4 with JUnit5.