Cleanup & Deployment Fix (#474)

* refactor: remove dead Feide logic * build: add .nvmrc file * test: remove feide references
boklisten · Oct 18, 2023 · f0e1f14 · f0e1f14
1 parent c820208
commit f0e1f14
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 123 deletions.
diff --git a/.nvmrc b/.nvmrc
@@ -0,0 +1 @@
+v18
diff --git a/src/application-config.ts b/src/application-config.ts
@@ -88,9 +88,6 @@ export const APP_CONFIG = {
     local: {
       name: "local",
     },
-    feide: {
-      name: "oauth2",
-    },
   },
   token: {
     refresh: {

diff --git a/src/auth/bl.auth.ts b/src/auth/bl.auth.ts
@@ -1,7 +1,6 @@
 import { Router } from "express";
 
 import { FacebookAuth } from "./facebook/facebook.auth";
-import { FeideAuth } from "./feide/feide.auth";
 import { GoogleAuth } from "./google/google.auth";
 import { LocalLoginCreator } from "./local/local-login-creator/local-login-creator";
 import { LocalLoginHandler } from "./local/local-login.handler";
@@ -54,6 +53,5 @@ export class BlAuth {
     new FacebookAuth(router, resHandler);
     new LocalAuth(router, resHandler, localLoginValidator, tokenHandler);
     new TokenEndpoint(router, resHandler, tokenHandler);
-    new FeideAuth(router, resHandler);
   }
 }
diff --git a/src/auth/feide/feide.auth.ts b/src/auth/feide/feide.auth.ts
diff --git a/src/auth/user/user-provider/user-provider.spec.ts b/src/auth/user/user-provider/user-provider.spec.ts
@@ -47,7 +47,7 @@ describe("UserProvider", () => {
       userValidStub.rejects(new BlError("user is not valid"));
 
       return expect(
-        userProvider.loginOrCreate("username@mail.com", "feide", "abcdef"),
+        userProvider.loginOrCreate("username@mail.com", "local", "abcdef"),
       ).to.eventually.be.rejectedWith(BlError, /user is not valid/);
     });
 
@@ -59,7 +59,7 @@ describe("UserProvider", () => {
       );
 
       return expect(
-        userProvider.loginOrCreate("username@mail.com", "feide", "abcde"),
+        userProvider.loginOrCreate("username@mail.com", "local", "abcde"),
       ).to.eventually.be.rejectedWith(
         BlError,
         /local login could not be created/,
@@ -72,7 +72,7 @@ describe("UserProvider", () => {
         userCreateStub.rejects(new BlError("user could not be created"));
 
         return expect(
-          userProvider.loginOrCreate("username@mail.com", "feide", "abcde"),
+          userProvider.loginOrCreate("username@mail.com", "local", "abcde"),
         ).to.eventually.be.rejectedWith(BlError, /user could not be created/);
       });
 
@@ -86,7 +86,7 @@ describe("UserProvider", () => {
         createTokenStub.resolves(tokens);
 
         return expect(
-          userProvider.loginOrCreate("username@mail.com", "feide", "abcdefg"),
+          userProvider.loginOrCreate("username@mail.com", "local", "abcdefg"),
         ).to.eventually.be.eql({ user: user, tokens: tokens });
       });
     });
@@ -102,7 +102,7 @@ describe("UserProvider", () => {
         createTokenStub.resolves(tokens);
 
         return expect(
-          userProvider.loginOrCreate("username@mail.com", "feide", "abcdefg"),
+          userProvider.loginOrCreate("username@mail.com", "local", "abcdefg"),
         ).to.eventually.be.eql({ user: user, tokens: tokens });
       });
     });