This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarsSelbekk
suggested changes
Jul 6, 2024
AdrianAndersen
force-pushed
the
sendgrid-templates
branch
from
July 7, 2024 13:26
fdeae7b
to
d0bafb0
Compare
AdrianAndersen
force-pushed
the
sendgrid-templates
branch
from
July 7, 2024 13:43
d0bafb0
to
9286b84
Compare
LarsSelbekk
reviewed
Jul 7, 2024
LarsSelbekk
suggested changes
Jul 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
AdrianAndersen
force-pushed
the
sendgrid-templates
branch
from
July 7, 2024 18:11
88fae9d
to
5d9d262
Compare
LarsSelbekk
approved these changes
Jul 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up email templating, using SendGrid Dynamic Templates. This means that we can generate the emails in the SendGrid GUI editor, and insert variables, attachments or custom HTML if need be. This approach can let us get rid of bl-email really quickly, as I just made our first template in like 5 minutes, for the email confirmation page. This design is quite simple tho, and we can for sure make something really pretty with their tooling.
Current confirm email template
The new one (I just copied over everything to SendGrid)