Build PR v1.7.2 #184
Open
Build PR v1.7.2 #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akshayurankar48
commented
Apr 15, 2025
akshayurankar48
commented
- Improvement: Integrated PHP Insights for automated code quality analysis.
…e/all-in-one-schemaorg-rich-snippets into phpinsights-aiosrs-fixes
compatablity with wordpress 6.8
Phpinsights aiosrs fixes
…e-schemaorg-rich-snippets into release-candidate
akshayurankar48
requested review from
Bhikule19,
Copilot,
vijetaR,
ShubhamGupta05 and
sushmak02
and removed request for
Copilot
There was a problem hiding this comment.
Copilot reviewed 7 out of 17 changed files in this pull request and generated 2 comments.
Files not reviewed (10)
- admin/bsf-analytics/class-bsf-analytics.php: Language not supported
- admin/bsf-analytics/modules/utm-analytics.php: Language not supported
- admin/bsf-analytics/version.json: Language not supported
- admin/index.php: Language not supported
- index.php: Language not supported
- init.php: Language not supported
- languages/all-in-one-schemaorg-rich-snippets.pot: Language not supported
- phpcs.xml.dist: Language not supported
- phpinsights.php: Language not supported
- settings.php: Language not supported
vijetaR
reviewed
Apr 15, 2025
vijetaR
reviewed
Apr 15, 2025
sushmak02
reviewed
Apr 15, 2025
README.md
Outdated
| @@ -83,6 +83,9 @@ No, the plugin provides an easy-to-use interface where you can add schema markup | |||
|
|
|||
| ## Changelog ## | |||
|
|
|||
| ### 1.7.2 ### | |||
| - Improvement: Integrated PHP Insights for automated code quality analysis. | |||
There was a problem hiding this comment.
- Improvement: Enhanced code quality and overall plugin performanc
there is no need to inform users about PHPInsights
sushmak02
reviewed
Apr 15, 2025
phpcs.xml.dist
Outdated
| @@ -16,9 +16,20 @@ | |||
| <exclude name="WordPress.WP.I18n.MissingTranslatorsComment" /> | |||
| </rule> | |||
|
|
|||
| <rule ref="WordPress-Core" /> | |||
| <rule ref="WordPress-Core"> | |||
| <exclude name="WordPress.PHP.YodaConditions.NotYoda" /> | |||
There was a problem hiding this comment.
Excluding Yoda conditions is not recommended
There was a problem hiding this comment.
updated the file @sushmak02
Bhikule19
reviewed
Apr 15, 2025
| @@ -74,31 +74,31 @@ public function define_constants() { | |||
| /** | |||
| * Admin bar menu. | |||
| */ | |||
| public function aiosrs_admin_bar() { | |||
| public function aiosrs_admin_bar(): void { | |||
There was a problem hiding this comment.
Can you please check if this : void can be ignored ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.