Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken PR build fix #10556

Merged
merged 2 commits into from
Mar 26, 2025
Merged

Broken PR build fix #10556

merged 2 commits into from
Mar 26, 2025

Conversation

djeada
Copy link
Contributor

@djeada djeada commented Jan 12, 2025

  • The PR build broke because the folder aws s3 event triggering contains spaces.
  • The script used find without quoting paths, causing shell word-splitting on spaces.
  • As a result, the python script tried to open scripts/aws instead of the full path.
  • Now proper quoting (and -print0) ensures the entire path is treated as one argument, even if it has spaces.

1. Two blank lines before the function definition (E302).  
2. Four-space indentation (E111, E114).  
3. Spaces around operators (E225).  
4. Correct alignment for comments.
@bregman-arie bregman-arie merged commit 51f7b89 into bregman-arie:master Mar 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants