Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Compat.@compat to mark public functions not exported #269

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

mofeing
Copy link
Member

@mofeing mofeing commented Dec 10, 2024

Closes #228

@mofeing
Copy link
Member Author

mofeing commented Dec 11, 2024

@jofrevalles @Todorbsc tests are failing because i stopped exporting a couple of deprecated functions. I can fix it now but let's discuss it in the next meeting so we choose which to export and which not.

@mofeing mofeing added this to the 0.8.x milestone Dec 26, 2024
@mofeing mofeing requested a review from jofrevalles January 8, 2025 11:34
@mofeing
Copy link
Member Author

mofeing commented Jan 9, 2025

This PR has no effect on execution of the code or API, so I'm merging it.

@mofeing mofeing merged commit 3819f63 into master Jan 9, 2025
2 of 5 checks passed
@mofeing mofeing deleted the public-spec branch January 9, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark public API with public keyword
2 participants