-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(): next #1609
Merged
feat(): next #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [rollup](https://github.com/rollup/rollup) from 4.11.0 to 4.22.4. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v4.11.0...v4.22.4) --- updated-dependencies: - dependency-name: rollup dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Visit the preview URL for this PR (updated for commit d0e55bd): https://novo-elements--pr1609-next-rp2onyhu.web.app (expires Fri, 25 Oct 2024 16:06:21 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f1783e19c2444272095017dd8ba433fff0ee3f61 |
* add logic for emitting an event on 'tab' for adjustments * move tab nav out of if * fix(Picker): Add logic for tab output for keyboard nav.
* fix(TabbedGroupPicker): Emit selected values on cancel * style(TabbedGroupPicker): remove unused import * Emit cancel event * Emit current tabs on cancel instead of only selected data * Add unit test for cancel
…tions are loading (#1617) * feat(NovoDataTable): Use spinner instead of loading dots when page options are loading * Re-add deleted quote * Use default size for spinner
…1618) Clear text input when exiting the input Do not clear inputs when a blur event targets a field's overlay
…1597) * feat(QueryBuilder): add isBetween option for number/timestamp fields Co-authored-by: Nathan Dickerson <nathan.dickerson@bullhorn.com> Co-authored-by: Kevin Florian <kevin.florian@bullhorn.com>
fix(Button): Set the native disabled attribute as well as preventing events
davidkbh
approved these changes
Oct 24, 2024
ndickerson
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
chore(deps): bump rollup from 4.11.0 to 4.22.4 #1606
fix(TabbedGroupPicker): adjusting indentation on groups #1605
fix(NovoDataTablePagination): updating displayed pages when setting page #1612
feat(Picker): Add Optional Keyboard Nav Logic #1610
fix(TabbedGroupPicker): Emit selected values on cancel #1613
feat(NovoDataTable): Use spinner instead of loading dots when page options are loading #1617
chore(deps): regenerating package-lock #1619
Verify that...
npm start
andnpm run build
still worksSafari
,Chrome
andFirefox
npm run lint
passesnpm test
passes and code coverage is increasednpm run build
still worksBullhorn Internal Developers
Novo Automation
Screenshots