Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): next #1609

Merged
merged 19 commits into from
Oct 24, 2024
Merged

feat(): next #1609

merged 19 commits into from
Oct 24, 2024

Conversation

dvoegelin
Copy link
Collaborator

@dvoegelin dvoegelin commented Sep 25, 2024

Description

chore(deps): bump rollup from 4.11.0 to 4.22.4 #1606
fix(TabbedGroupPicker): adjusting indentation on groups #1605
fix(NovoDataTablePagination): updating displayed pages when setting page #1612
feat(Picker): Add Optional Keyboard Nav Logic #1610
fix(TabbedGroupPicker): Emit selected values on cancel #1613
feat(NovoDataTable): Use spinner instead of loading dots when page options are loading #1617
chore(deps): regenerating package-lock #1619

Verify that...

  • Any related demos were added and npm start and npm run build still works
  • New demos work in Safari, Chrome and Firefox
  • npm run lint passes
  • npm test passes and code coverage is increased
  • npm run build still works

Bullhorn Internal Developers

  • Run Novo Automation
Screenshots

@dvoegelin dvoegelin self-assigned this Sep 25, 2024
Copy link
Contributor

github-actions bot commented Sep 25, 2024

Visit the preview URL for this PR (updated for commit d0e55bd):

https://novo-elements--pr1609-next-rp2onyhu.web.app

(expires Fri, 25 Oct 2024 16:06:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f1783e19c2444272095017dd8ba433fff0ee3f61

dvoegelin and others added 13 commits September 27, 2024 09:46
* add logic for emitting an event on 'tab' for adjustments

* move tab nav out of if

* fix(Picker): Add logic for tab output for keyboard nav.
* fix(TabbedGroupPicker): Emit selected values on cancel

* style(TabbedGroupPicker): remove unused import

* Emit cancel event

* Emit current tabs on cancel instead of only selected data

* Add unit test for cancel
…tions are loading (#1617)

* feat(NovoDataTable): Use spinner instead of loading dots when page options are loading

* Re-add deleted quote

* Use default size for spinner
…1618)

Clear text input when exiting the input

Do not clear inputs when a blur event targets a field's overlay
…1597)

* feat(QueryBuilder): add isBetween option for number/timestamp fields
Co-authored-by: Nathan Dickerson <nathan.dickerson@bullhorn.com>
Co-authored-by: Kevin Florian <kevin.florian@bullhorn.com>
fix(Button): Set the native disabled attribute as well as preventing events
@davidkbh davidkbh merged commit 286c486 into master Oct 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants