Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DatePicker): Add optional dateForInitialView input #1635

Merged
merged 5 commits into from
Nov 21, 2024
Merged

feat(DatePicker): Add optional dateForInitialView input #1635

merged 5 commits into from
Nov 21, 2024

Conversation

jordanbullhorn
Copy link
Contributor

@jordanbullhorn jordanbullhorn commented Nov 20, 2024 •
edited
Loading

Description

Added an optional input for DatePickerInput flowing to DatePicker called dateForInitialView to make sure a certain month shows initially in the date picker when opened that is not the current month/date.

Verify that...

  • Any related demos were added and npm start and npm run build still works
  • New demos work in Safari, Chrome and Firefox
  • npm run lint passes
  • npm test passes and code coverage is increased
  • npm run build still works

Bullhorn Internal Developers

  • Run Novo Automation
Screenshots

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 24471c2):

https://novo-elements--pr1635-f-bh-90464-d6s91pto.web.app

(expires Wed, 27 Nov 2024 21:43:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f1783e19c2444272095017dd8ba433fff0ee3f61

@jordanbullhorn jordanbullhorn changed the title date-picker default to previous month feat(DatePicker): Add optional dateForInitialView input Nov 20, 2024
@jordanbullhorn jordanbullhorn added the enhancement improvements to existing functionality that have never existed before label Nov 21, 2024
@dvoegelin dvoegelin merged commit e56dbb0 into next Nov 21, 2024
12 checks passed
@dvoegelin dvoegelin deleted the f/bh-90464 branch November 21, 2024 17:25
@dvoegelin dvoegelin mentioned this pull request Nov 21, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvoegelin dvoegelin dvoegelin approved these changes

@monroepe monroepe monroepe approved these changes

Assignees

@jordanbullhorn jordanbullhorn

Labels
enhancement improvements to existing functionality that have never existed before
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordanbullhorn @monroepe @dvoegelin