Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Types): Fixing data table filter value type #1640

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

ndickerson
Copy link
Member

Description

The type has been incorrect for a while now, so fixing the filter value so that it matches up with the current code - the filter value can be any object, string, number, etc.

Verify that...

  • Any related demos were added and npm start and npm run build still works
  • New demos work in Safari, Chrome and Firefox
  • npm run lint passes
  • npm test passes and code coverage is increased
  • npm run build still works

Bullhorn Internal Developers

  • Run Novo Automation
Screenshots

Copy link
Contributor

Visit the preview URL for this PR (updated for commit 03e27f0):

https://novo-elements--pr1640-f-data-table-types-jrony05g.web.app

(expires Wed, 25 Dec 2024 18:04:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f1783e19c2444272095017dd8ba433fff0ee3f61

@ndickerson ndickerson merged commit 47a58e0 into next Dec 19, 2024
6 checks passed
@ndickerson ndickerson deleted the f/data-table-types branch December 19, 2024 18:26
@dvoegelin dvoegelin mentioned this pull request Dec 19, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants